zoushiyang/page-agent
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #512 from linked-danis/fix/scroll-predicate-types

Browse Source 
Fix scroll predicate types (boolean | null -> boolean)
This commit is contained in:
Simon
2026-06-11 21:22:31 +08:00
committed by GitHub
parent 0f3f639497 903c2a736c
commit 7dffaa4718
1 changed files with 14 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
packages/page-controller/src/actions.ts
View File

@@ -336,11 +336,13 @@ export async function scrollVertically(scroll_amount: number, element?: HTMLElem
const dy = scroll_amount const dy = scroll_amount
const bigEnough = (el: HTMLElement) => el.clientHeight >= window.innerHeight * 0.5 const bigEnough = (el: HTMLElement) => el.clientHeight >= window.innerHeight * 0.5
const canScroll = (el: HTMLElement | null) => const canScroll = (el: HTMLElement | null): boolean =>
Boolean(
el && el &&
/(auto|scroll|overlay)/.test(getComputedStyle(el).overflowY) && /(auto|scroll|overlay)/.test(getComputedStyle(el).overflowY) &&
el.scrollHeight > el.clientHeight && el.scrollHeight > el.clientHeight &&
bigEnough(el) bigEnough(el)
)
// @deprecated Heuristic container search. // @deprecated Heuristic container search.
// Unreliable in multi-panel layouts. Should guide LLMs to use indexed scroll for consistency. // Unreliable in multi-panel layouts. Should guide LLMs to use indexed scroll for consistency.
@@ -479,11 +481,13 @@ export async function scrollHorizontally(scroll_amount: number, element?: HTMLEl
const dx = scroll_amount const dx = scroll_amount
const bigEnough = (el: HTMLElement) => el.clientWidth >= window.innerWidth * 0.5 const bigEnough = (el: HTMLElement) => el.clientWidth >= window.innerWidth * 0.5
const canScroll = (el: HTMLElement | null) => const canScroll = (el: HTMLElement | null): boolean =>
Boolean(
el && el &&
/(auto|scroll|overlay)/.test(getComputedStyle(el).overflowX) && /(auto|scroll|overlay)/.test(getComputedStyle(el).overflowX) &&
el.scrollWidth > el.clientWidth && el.scrollWidth > el.clientWidth &&
bigEnough(el) bigEnough(el)
)
// @deprecated Same heuristic container search as scrollVertically. // @deprecated Same heuristic container search as scrollVertically.
// TODO: Remove once LLMs reliably use indexed scrolling via data-scrollable. // TODO: Remove once LLMs reliably use indexed scrolling via data-scrollable.